feat: Cost Control Center

[dreamwing]

Implementation of Cost Control Center frontend and backend as specified in the PRD. Includes diagnostic engine, optimizer service, and dashboard UI.

[dreamwing]

@codex review please~

[dreamwing]

@greptileai review thx~

[greptile-apps]

Greptile Summary

This PR implements the Cost Control Center — a diagnostic engine + optimizer UI that scans token usage data, surfaces 7–10 cost-saving recommendations, and lets users apply or roll back configuration changes with one tap. The backend adds DiagnosticsEngine (src/services/diagnostics.js), OptimizerService (src/services/optimizer.js), a pricing.js model database, two new API route files, and a shared utils/paths.js module. The frontend adds a 3D flip-card UI over the existing Token Economy view, a live diagnostic trigger banner, and an optimization history timeline.

The backend logic is well-designed: path-traversal protection on the undo endpoint, execFile (not exec) in openclaw_config.js, pre-mutation config backups, and a solid test suite.

Issues found:

• public/index.html contains 5 unresolved git merge conflict markers (lines 378, 384, 456, 474, 500). The literal <<<<<<< HEAD, =======, and >>>>>>> strings will be rendered as visible text, corrupting the daily detail drill-down panel and the "Fully Optimized" history section. This is a blocking issue.
• Triple duplicate id="cache-hit-rate" in public/index.html (lines 309, 383, 434) — two are direct duplicates (front card and back card), the third was introduced by the unresolved conflict. getElementById always returns the first match, so the optimizer back card's cache hit rate will never be populated.
• diagnosticsEngine_cache = null in dashboard.js (line 958) — references an undefined variable after an undo operation, a copy-paste artefact from the server-side service.
• "push" npm script in package.json chains git push with ci-watch.sh, requiring gh CLI and jq for all contributors — better kept as a local alias.
• D04_idleDaysThreshold is absent from the defaults object in diagnostics.js, making it unoverridable via diagnostics.config.json without knowing the undocumented key name.

Confidence Score: 2/5

• Not safe to merge — unresolved merge conflict markers in public/index.html will visibly corrupt the dashboard UI for all users.
• The backend services, route handlers, and test coverage are solid and well-structured. However, public/index.html ships with five unresolved git merge conflict markers that will render as literal text and break the daily detail panel and optimizer history section. The accompanying duplicate id="cache-hit-rate" and diagnosticsEngine_cache reference error are additional runtime bugs introduced in the same files. These frontend issues must be fixed before merging.
• public/index.html requires immediate attention to resolve merge conflicts and deduplicate element IDs. public/js/dashboard.js line 958 needs the diagnosticsEngine_cache reference removed.

Important Files Changed

Filename	Overview
public/index.html	Contains 5 unresolved git merge conflict markers and 3 duplicate id="cache-hit-rate" elements — both are breaking bugs that corrupt page layout and silence the optimizer's cache-hit display.
public/js/dashboard.js	Adds the full optimizer/diagnostics UI logic. One logic bug: diagnosticsEngine_cache = null references an undefined variable after undo. Otherwise well-structured with proper escaping, WS-driven refresh, and graceful error handling.
src/services/diagnostics.js	New DiagnosticsEngine implementing 7 active rules (D01–D09). Cache TTL, empty-data guard, and format normalization are solid. Minor: D04_idleDaysThreshold is not included in the defaults object, making it non-configurable via the config file.
src/services/optimizer.js	OptimizerService correctly backs up config before mutations, has path-traversal protection for skill names, and supports per-action undo via backup restoration. Well-tested.
src/routes/optimizations.js	Undo endpoint uses path.basename to strip directory components and verifies the resolved path starts within BACKUPS_DIR, correctly preventing path-traversal attacks.
package.json	Adds a "push" npm script that chains git push with ci-watch.sh; this is a developer convenience tool that shouldn't be in the shared package manifest as it requires gh CLI and jq and affects all contributors.
src/services/openclaw_config.js	New service wrapping the openclaw CLI for config reads and writes, with a direct file-read fallback. Correctly uses execFile (not exec) to avoid shell injection.

Sequence Diagram

sequenceDiagram
    participant UI as Dashboard (Browser)
    participant DR as GET /api/diagnostics
    participant DE as DiagnosticsEngine
    participant OR as POST /api/optimize/:id
    participant OS as OptimizerService
    participant OC as OpenClawConfig (CLI)
    participant UN as POST /api/optimizations/undo

    UI->>DR: fetchDiagnostics()
    DR->>DE: runDiagnostics()
    DE->>OC: getRawConfig()
    OC-->>DE: agents config
    DE->>DE: Read latest.json stats
    DE->>DE: Run D01–D09 rules
    DE-->>DR: { actions, totalMonthlySavings }
    DR-->>UI: JSON (strips _rawData unless ?verbose)

    UI->>OR: handleOpt(actionId, meta)
    OR->>OS: applyAction(actionId, savings, meta)
    OS->>OS: backupConfig() → data/backups/
    OS->>OC: setConfig(key, value)
    OC-->>OS: { success }
    OS->>OS: logOptimization() → optimizations.jsonl
    OS->>DE: invalidateCache()
    OS-->>OR: { success, backupPath }
    OR-->>UI: result

    UI->>UN: handleUndo(backupPath)
    UN->>OS: restoreBackup(resolved path)
    OS->>OC: setConfig(key, value) × N
    OS->>OS: logOptimization(UNDO)
    OS->>DE: invalidateCache()
    OS-->>UN: { success, restoredKeys }
    UN-->>UI: result

Loading

_{Last reviewed commit: 9fbc8c1}

[greptile-apps]

Unresolved git merge conflict markers

The file contains five unresolved merge conflict markers (<<<<<<< HEAD, =======, >>>>>>>) at lines 378, 384, 456, 474, and 500. These are not valid HTML and will be rendered as literal visible text in the browser, breaking the page layout in both the daily detail drill-down panel and the "Fully Optimized" success state's history section.

The conflict appears to be between the current branch's history-section UI (lines 456–473) and a daily-detail block from commit 3f45e78 (lines 474–500). You need to resolve which version of this content to keep, remove the conflict markers, and ensure there are no duplicate elements (e.g. id="daily-detail" and id="cache-hit-rate" already appear earlier in the file).

[greptile-apps]

Duplicate id="cache-hit-rate" causes stale display

The element ID "cache-hit-rate" is used three times in this file: line 309 (front card banner), line 383 (inside the merge conflict zone), and line 434 (optimizer back card's cost-comparison row).

document.getElementById('cache-hit-rate') always returns the first matching element. This means the renderOptimizerList() call in dashboard.js (which tries to update the cache hit rate on the optimizer back card) will silently update the front-card element instead, leaving the back card's display permanently showing —.

After resolving the merge conflict, keep a single id="cache-hit-rate" element or use distinct IDs (e.g. "front-cache-hit-rate" vs "back-cache-hit-rate") and update the JS selectors accordingly.

[greptile-apps]

Reference to undefined variable diagnosticsEngine_cache

diagnosticsEngine_cache is not declared anywhere in the frontend JavaScript. This appears to be a copy-paste of the server-side cache-invalidation pattern from src/services/diagnostics.js, but it has no meaning in the browser context.

In non-strict mode this will silently create an unintentional global variable. In strict mode (or with a linter) it would throw a ReferenceError. The intent is presumably to ensure fresh data is fetched — the subsequent await fetchDiagnostics() already handles that. Remove this line:

Suggested change

	diagnosticsEngine_cache = null; // Assuming this is a global cache variable
	await fetchDiagnostics();

[greptile-apps]

Developer-workflow script committed to package.json

The "push" script (git push && ./.github/scripts/ci-watch.sh) is a personal developer convenience that runs the CI watcher after every push. Committing it to package.json means it applies to all contributors and CI environments, where ci-watch.sh requires the GitHub CLI (gh) and jq to be installed and authenticated. It also shadows any future npm publish-like tooling that might need a push hook.

Consider keeping this script local (e.g. in a personal .npmrc, a Makefile, or a git alias) rather than baking it into the shared package.json.

[greptile-apps]

D04_idleDaysThreshold missing from default thresholds

Every other threshold is declared in the defaults object so it's visible in data/diagnostics.config.json.example, but D04_idleDaysThreshold is only referenced inline as thresholds.D04_idleDaysThreshold || 7 on line 320. This means it can't be overridden via diagnostics.config.json without first knowing the undocumented key name.

Suggested change

	const defaults = {
	D01_modelCostRatio: 0.5, // trigger if single model > 50% of total cost
	D06_cacheHitRateMin: 0.10, // trigger if cache hit rate < 10%
	D06_cacheableRatio: 0.80, // assume 80% of input is cacheable
	D09_outputRatioThreshold: 0.10, // trigger if output/input > 10%
	D09_minOutputTokens: 1000, // minimum output tokens to trigger
	D09_reductionFactor: 0.30, // concise mode reduces output by 30%
	D05_thinkingProportion: 0.40, // 40% of output is thinking
	D05_reductionRatio: 0.75 // minimal mode cuts thinking by 75%
	};
	const defaults = {
	D01_modelCostRatio: 0.5, // trigger if single model > 50% of total cost
	D06_cacheHitRateMin: 0.10, // trigger if cache hit rate < 10%
	D06_cacheableRatio: 0.80, // assume 80% of input is cacheable
	D09_outputRatioThreshold: 0.10, // trigger if output/input > 10%
	D09_minOutputTokens: 1000, // minimum output tokens to trigger
	D09_reductionFactor: 0.30, // concise mode reduces output by 30%
	D05_thinkingProportion: 0.40, // 40% of output is thinking
	D05_reductionRatio: 0.75, // minimal mode cuts thinking by 75%
	D04_idleDaysThreshold: 7 // skills unused for > 7 days are flagged idle
	};

Update data/diagnostics.config.json.example to include the key as well.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9fbc8c16c6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Handle symlinked managed skills in A04 removal

The A04 optimizer only whitelists entries where entry.isDirectory() is true, so selected managed skills that are symlinked directories are treated as unknown and skipped; if the selection contains only such skills, the action fails with "Failed to move any skills." This conflicts with the diagnostics scanner, which explicitly includes symlinked skill folders (src/services/diagnostics.js handles isSymbolicLink()), so users can be shown removable skills that cannot actually be removed.

Useful? React with 👍 / 👎.

[chatgpt-codex-connector]

Skip A06 recommendation when caching is already enabled

The caching recommendation is triggered solely by low observed cache-hit rate and does not check whether contextPruning.mode is already cache-ttl, so users who already enabled prompt caching can still be told to apply A06 and shown projected savings for a no-op change. This produces inaccurate optimization output and repeated suggestions that cannot materially reduce cost in that configuration.

Useful? React with 👍 / 👎.