Open
Conversation
0xbigz
reviewed
Apr 13, 2022
| let markets = &markets.load()?; | ||
| let user_positions = &mut user_positions.load_mut()?; | ||
| let funding_payment_history = &mut funding_payment_history.load_mut()?; | ||
| settle_funding_payment(user, user_positions, markets, funding_payment_history, now)?; |
Member
There was a problem hiding this comment.
would it be better to settle funding and then set the collateral_before?
think it more accurately reflects the user collateral just before deposit
0xbigz
reviewed
Apr 13, 2022
| let markets = &markets.load()?; | ||
| let user_positions = &mut user_positions.load_mut()?; | ||
| let funding_payment_history = &mut funding_payment_history.load_mut()?; | ||
| settle_funding_payment(user, user_positions, markets, funding_payment_history, now)?; |
Member
There was a problem hiding this comment.
here as well for collateral_before
0xbigz
reviewed
Apr 20, 2022
| @@ -0,0 +1,27 @@ | |||
| use anchor_lang::prelude::*; | |||
|
|
|||
| pub const UNINITIALIZED_NAME: [u8; 32] = [32; 32]; | |||
Member
There was a problem hiding this comment.
is this just all spaces? can emojis be used in the name?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.