Skip to content

feat(design-system): add StatusBadgeV2 component [AR-60237]#477

Merged
mmurawski-dn merged 7 commits into
drivenets:mainfrom
mmurawski-dn:drivenets/michal/AR-60237-status-badge-v2
May 15, 2026
Merged

feat(design-system): add StatusBadgeV2 component [AR-60237]#477
mmurawski-dn merged 7 commits into
drivenets:mainfrom
mmurawski-dn:drivenets/michal/AR-60237-status-badge-v2

Conversation

@mmurawski-dn
Copy link
Copy Markdown
Collaborator

Screencast_20260513_134958.webm

@netlify
Copy link
Copy Markdown

netlify Bot commented May 13, 2026

Deploy Preview for drivenets-design-system ready!

Name Link
🔨 Latest commit 1f8936e
🔍 Latest deploy log https://app.netlify.com/projects/drivenets-design-system/deploys/6a06eee8e495d10008f23781
😎 Deploy Preview https://deploy-preview-477--drivenets-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added design-system eslint-plugin cursor PR that changes cursor rules, skills, etc. labels May 13, 2026
@mmurawski-dn mmurawski-dn force-pushed the drivenets/michal/AR-60237-status-badge-v2 branch from 5ed0d40 to 5835097 Compare May 13, 2026 11:51
@github-actions github-actions Bot removed the cursor PR that changes cursor rules, skills, etc. label May 13, 2026
@mmurawski-dn mmurawski-dn force-pushed the drivenets/michal/AR-60237-status-badge-v2 branch from 5835097 to 0a49eb6 Compare May 13, 2026 12:01
>
{hasIcon && (
<span className={styles.icon}>
<DsIcon icon={resolvedIcon} size="tiny" filled aria-hidden="true" style={iconStyle} />
Copy link
Copy Markdown
Collaborator

@iromanchuk-dn iromanchuk-dn May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it possible control Icon size via size prop and do not override it with inline css?
Even if you have to override size, what not via css class?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, but not the 12px size, tiny is 16px (smallest one)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it shouldn't be like that. Let's bug designers to add new size for the icon component.
Let's create a ticket to add new icon size variation. Leave a comment here to remove css override when that ticket is done.

Copy link
Copy Markdown
Collaborator

@iromanchuk-dn iromanchuk-dn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@mmurawski-dn mmurawski-dn force-pushed the drivenets/michal/AR-60237-status-badge-v2 branch from 8b73f6b to e5f1ff8 Compare May 13, 2026 13:34
@mmurawski-dn mmurawski-dn merged commit ba113ed into drivenets:main May 15, 2026
24 checks passed
@mmurawski-dn mmurawski-dn deleted the drivenets/michal/AR-60237-status-badge-v2 branch May 15, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants