Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates the GitHub Actions workflow to pin the release-plz job to ubuntu-22.04 instead of ubuntu-latest, and includes a version bump for the ostool package.
Changes:
- Changed the
release-plzjob's runner fromubuntu-latesttoubuntu-22.04in the release workflow - Bumped ostool version from 0.8.9 to 0.8.10 in Cargo.toml and Cargo.lock
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/release.yml | Updates the release-plz job to run on ubuntu-22.04 instead of ubuntu-latest |
| ostool/Cargo.toml | Increments package version from 0.8.9 to 0.8.10 |
| Cargo.lock | Updates the locked version for ostool package to 0.8.10 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| readme = "../README.md" | ||
| repository = "https://github.com/drivercraft/ostool" | ||
| version = "0.8.9" | ||
| version = "0.8.10" |
There was a problem hiding this comment.
The PR title indicates this change is only about updating the release-plz job's runtime environment to ubuntu-22.04. However, this PR also includes a version bump from 0.8.9 to 0.8.10. The version bump should either be mentioned in the PR title/description, or if it's unrelated to the workflow change, it should be in a separate PR for clarity.
| release-plz: | ||
| if: ${{ github.repository_owner == 'drivercraft' && (github.event_name == 'workflow_dispatch' || github.event.workflow_run.conclusion == 'success') }} | ||
| runs-on: ubuntu-latest | ||
| runs-on: ubuntu-22.04 |
There was a problem hiding this comment.
The release-plz job is being changed to use ubuntu-22.04, but the release-plz-pr job on line 45 still uses ubuntu-latest. Since both jobs use the release-plz action and likely have similar dependencies (both reference the same install-rust and setup-libudenv steps), consider whether the release-plz-pr job should also be pinned to ubuntu-22.04 for consistency. If there's a specific reason only one job needs pinning, that's fine, but this inconsistency should be intentional.
1 participant
No description provided.