Skip to content

Resolve node 184 open question in fix-hera-plan-dag-hygiene design.md #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anutron merged 1 commit into from
Jul 30, 2026
+4 −4
Merged

Resolve node 184 open question in fix-hera-plan-dag-hygiene design.md #915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions openspec/changes/archive/2026-07-30-fix-hera-plan-dag-hygiene/design.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,11 @@ Considered and rejected: auto-archiving a freelance role once its binding ends (
2. `CancelHeraPlannedNode(343)`, `CancelHeraPlannedNode(358)` — the exact pre-existing store method Bug A's own fix relies on; this migration is effectively "run the same cascade the code fix would have run, had it existed a month ago."
3. `ArchiveHeraRole(813)`, `ArchiveHeraRole(814)` — pre-existing store method.
4. `EndHeraBinding(803, endReason)`, `EndHeraBinding(804, endReason)` (or the equivalent store call — see `internal/db/hera.go` for the exact signature) with an end reason describing "task finished, binding never closed."
5. Node 184 is explicitly excluded — no mutation touches it.
6. Verify via `sqlite3 -readonly ~/.argus/data.sql`: 343/358 no longer satisfy `ListHeraPlannedNodes`'s WHERE clause; 813/814 have non-null `archived_at`; bindings 803/804 have non-null `ended_at`; role 184 is unchanged.
5. `CancelHeraPlannedNode(184)` — added after Aaron's 2026-07-30 decision (see Open Questions below): rather than assign role 184 a project, he chose to cancel the node outright. Same store method as step 2; no special-casing needed since a coordinator-approved cancel and a cascade-triggered cancel are indistinguishable at the store layer.
6. Verify via `sqlite3 -readonly ~/.argus/data.sql`: 343/358/184 no longer satisfy `ListHeraPlannedNodes`'s WHERE clause; 813/814 have non-null `archived_at`; bindings 803/804 have non-null `ended_at`.

**Rollback:** restore from the fresh pre-mutation backup; all four mutations are simple column stamps with no cascading side effects (cancel/archive do not touch bindings; ending a binding does not touch the role), so no compensating script is needed beyond a straight file restore.
**Rollback:** restore from the fresh pre-mutation backup; all five mutations are simple column stamps with no cascading side effects (cancel/archive do not touch bindings; ending a binding does not touch the role), so no compensating script is needed beyond a straight file restore.

## Open Questions

- What `argus_project` should role 184 ("2a-team" under "sherlock-mvp") target? Left to Aaron — reported back via `hera_send` as an open question, not resolved in this change.
- ~~What `argus_project` should role 184 ("2a-team" under "sherlock-mvp") target?~~ **Resolved 2026-07-30**: Aaron decided to cancel the node rather than assign it a project (relayed via the "hera-leaks" coordinator, message #3875). Folded into the Migration Plan's Part 2 cleanup above as step 5 — no code change, since `CancelHeraPlannedNode` already exists and needs no new caller.
Loading