Fix DAG arrow-key nav stolen by Details roster scroll - #918
Merged
Conversation
The Agents roster (Details region, coordinator view) claimed j/k/Up/Down FIRST whenever it had unseen rows, falling through to the embedded plan widget only once the roster hit its scroll bound -- so arrow keys aimed at the plan DAG instead silently scrolled the roster above it. Split the keysets: the roster now scrolls exclusively via PgUp/PgDn, and every plan-nav key reaches planview.Widget unconditionally. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/tui/hera/page.go'srosterScrollDelta/handleDetailsKeynow route PgUp/PgDn exclusively toDetailsView.ScrollRoster, and j/k/Up/Down/h/l/Enter/Space/Esc reachplanview.Widget.InputHandlerunconditionally — the two surfaces can no longer contend for the same keystroke.context/knowledge/gotchas/hera-view.mdbullet + updated the README's plan-DAG key table (PgUp/PgDn row added, arrow-key row corrected).Test plan
internal/tui/hera/dag_test.go:TestFocusRouting_ArrowKeysStayWithinFocusedRegion(end-to-end SimulationScreen test proving rail-focused keys are unaffected and DAG-focused arrows never leak to the rail cursor or roster scroll),TestHandleDetailsKey_ArrowsAlwaysReachPlanNeverRoster,TestHandleDetailsKey_PgDnPgUpScrollRoster.TestRosterScrollDelta(details_test.go) for the new PgUp/PgDn keyset.make pre-prclean (build, vet, fmt-check, lint-pr, test-cover-gate all pass;vulnfails only on pre-existing advisory stdlib CVEs, confirmed toolchain-only and CI-continue-on-error, unrelated to this change).internal/tui/...suite green.🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com