Auto-revive a dead or stuck hera_send recipient - #922
Merged
Conversation
…evive) A coordinator sending to an explicit, different recipient now revives it first via the existing hera_revive/ReviveRole primitive, reused verbatim. Soft-fail throughout: no live binding, a lookup error, a revive error, or the reviver not being wired all skip silently and never block the send. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…hera-send-auto # Conflicts: # context/knowledge/index.md
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hera_sendnow auto-revives an explicit-to, different recipient before delivering — reusinginternal/hera.ReviveRole/s.heraReviveverbatim, the exact same primitivehera_revivealready calls. No new gating logic.heraRevivenot being wired (daemon didn't configure a reviver) all skip silently (or Warn-log) and never block the send.hera_sendresponse gains a- **revive**: <outcome>line (via the existingheraReviveOutcomeMessage) and a matchingslog.Info("[hera] revive", ...)log line, so an auto-triggered revive is indistinguishable from a manualhera_revivecall.to(never the worker/freelance default-to-coordinator route), and a different role than the caller's own — a worker/freelance default-route send or a coordinator self-send never triggers it.OpenSpec
Routed through
openspec/changes/add-hera-send-auto-revive/(proposal + design + delta spec againsthera-messaging), archived in this same PR toopenspec/changes/archive/2026-08-03-add-hera-send-auto-revive/with the delta folded intoopenspec/specs/hera-messaging/spec.md.Test plan
internal/mcp/hera_send_revive_test.go: dead recipient restarted before send; busy/blocked/live-coordinator skip outcomes still deliver; no-live-binding recipient doesn't block send; nil reviver doesn't block send; revive error doesn't block send; worker/freelance default route never triggers; coordinator self-send never triggers.make pre-prgreen (build, vet, fmt-check, lint-pr, vuln advisory-only stdlib CVEs confirmed pre-existing/toolchain-only, test-cover-gate 88.8% ≥ 88% floor).openspec validate --all --strictpasses (57/57 specs).🤖 Generated with Claude Code