fix: CI code quality checks and remove duplicate README#25
Merged
dronefreak merged 6 commits intomasterfrom Jan 9, 2026
Merged
fix: CI code quality checks and remove duplicate README#25dronefreak merged 6 commits intomasterfrom
dronefreak merged 6 commits intomasterfrom
Conversation
- Format code with black for consistent styling - Fix import ordering with isort - Remove unused imports (F401 flake8 errors) - Remove unused typing imports from transform.py - Remove unused layer imports from cabinet.py - Remove unused Optional from common.py - Remove unused TrainingError from train.py - Remove unused Callable from profiler.py - Remove .github/README.md (duplicate of main README) All critical CI checks now pass: - black --check: ✓ - isort --check-only: ✓ - flake8 critical errors: ✓
- Update actions/upload-artifact from v3 to v4 - Update actions/cache from v3 to v4 Fixes deprecation warnings in CI pipeline.
Replace types-all with specific type stubs (types-PyYAML, numpy) to avoid dependency resolution errors. The types-all meta-package has issues with types-pkg-resources which no longer exists. Since we use --ignore-missing-imports, we only need type stubs for core dependencies that we actually use in type annotations.
Add version suffix to cache key to force invalidation of old cached pre-commit environments that still reference types-all.
- Replace flake8 + isort with ruff for faster linting - Update all hook versions to latest (pre-commit-hooks v6.0.0, black 25.12.0, mypy v1.19.1) - Simplify mypy dependencies (types-PyYAML, types-requests) - Add conventional-pre-commit for commit message validation - Remove redundant hooks (docformatter, pyupgrade, nbstripout, pylint) - Bust cache to v3 to force new environment - Fix unused imports detected by ruff in test files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All critical CI checks now pass: