Const-ify the descriptor on Message#137
Conversation
goffrie
left a comment
There was a problem hiding this comment.
For some reason I had thought you wanted this to be &self for object-safety, but of course Message already isn't object-safe so that doesn't make sense. This seems better.
c3f9c77 to
95808a4
Compare
|
Got back around to updating this. I think because the clippy CI command is cd-ing into the |
95808a4 to
0101e26
Compare
| self, | ||
| "fn descriptor(&self) -> ::std::option::Option<::pb_jelly::MessageDescriptor>", | ||
| "const DESCRIPTOR: ::std::option::Option<::pb_jelly::MessageDescriptor> = ", | ||
| start=" (", |
There was a problem hiding this comment.
this causes a double space :p
though is there any point to having the parens at all?
|
|
This makes it possible to use the descriptor from a const context.