Skip to content

Const-ify the descriptor on Message#137

Open
cyang1 wants to merge 1 commit into
dropbox:mainfrom
cyang1:const-descriptor
Open

Const-ify the descriptor on Message#137
cyang1 wants to merge 1 commit into
dropbox:mainfrom
cyang1:const-descriptor

Conversation

@cyang1

@cyang1 cyang1 commented Dec 10, 2021

Copy link
Copy Markdown
Contributor

This makes it possible to use the descriptor from a const context.

@goffrie goffrie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason I had thought you wanted this to be &self for object-safety, but of course Message already isn't object-safe so that doesn't make sense. This seems better.

@cyang1

cyang1 commented Dec 17, 2021

Copy link
Copy Markdown
Contributor Author

Got back around to updating this.

I think because the clippy CI command is cd-ing into the proto_pbtest directory and then running cargo clippy, it's not picking up the [patch.crates-io] from pb-test/Cargo.yaml. Not sure what we want to do about that.

self,
"fn descriptor(&self) -> ::std::option::Option<::pb_jelly::MessageDescriptor>",
"const DESCRIPTOR: ::std::option::Option<::pb_jelly::MessageDescriptor> = ",
start=" (",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this causes a double space :p
though is there any point to having the parens at all?

@CLAassistant

CLAassistant commented Apr 16, 2022

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants