Skip to content

Use criterion instead of unstable libtest for benches#179

Open
j-g00da wants to merge 3 commits into
dropbox:mainfrom
j-g00da:criterion
Open

Use criterion instead of unstable libtest for benches#179
j-g00da wants to merge 3 commits into
dropbox:mainfrom
j-g00da:criterion

Conversation

@j-g00da

@j-g00da j-g00da commented May 29, 2025

Copy link
Copy Markdown

Resolves #20

@CLAassistant

CLAassistant commented May 29, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@j-g00da

j-g00da commented May 29, 2025

Copy link
Copy Markdown
Author
  1. bench.rs moved to benches:

It is not possible to include benchmarks in code in the src/ directory as one might with the regular benchmark harness.

  1. Making pb_test::gen public:

It is not possible to benchmark non-pub functions. External benchmarks, including those using Criterion.rs, are compiled as a separate crate, and non-pub functions are not visible to the benchmarks.

https://bheisler.github.io/criterion.rs/book/user_guide/known_limitations.html

@j-g00da j-g00da marked this pull request as ready for review May 29, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate benchmarks to criterion

2 participants