Skip to content

Don't apply #[no_mangle] pointlessly#14

Open
syvb wants to merge 1 commit into
dropbox:masterfrom
syvb:rm-pointless-no_mangle
Open

Don't apply #[no_mangle] pointlessly#14
syvb wants to merge 1 commit into
dropbox:masterfrom
syvb:rm-pointless-no_mangle

Conversation

@syvb

@syvb syvb commented Jun 14, 2021

Copy link
Copy Markdown

It doesn't make sense to apply #[no_mangle] to structs/enums/type aliases, since the names of those items are not mangled, or even directly included in compiled binaries. This was only accepted by rustc accidentally, and newer versions of the compilers warn about this:

warning: attribute should be applied to a function or static
 --> src/ffi/mod.rs:3:1
  |
3 | #[no_mangle]
  | ^^^^^^^^^^^^
4 | #[cfg(feature="std")]
5 | use std::{thread,panic, io, boxed, any, string};
  | ------------------------------------------------ not a function or static
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!

Furthermore, this can even cause compiler bugs in the latest nightly.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants