Skip to content

improve: Add optional destination parameter to ILogInAs #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
petarbasic wants to merge 1 commit into
base: 1.x
Choose a base branch
from
Open

improve: Add optional destination parameter to ILogInAs #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions tests/helpers/test-methods.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,13 @@ module.exports = {
await expect(page.locator('body.user-logged-in').first()).toHaveCount(0);
await expect(page).toHaveURL(/.*user\/login/);
},
ILogInAs: async ([page, username]) => {
await page.goto('/user/login');
ILogInAs: async ([page, username, destination]) => {
// Optionally set a destination to control the post-login redirect. This
// can be used to avoid being redirected to the admin dashboard, which
// renders views blocks that can cause race conditions during parallel
// test execution. Example: ILogInAs([page, 'dru_admin', '/user'])
const loginUrl = destination ? `/user/login?destination=${destination}` : '/user/login';
await page.goto(loginUrl);
await expect(page.locator('form.user-login-form')).toBeVisible;
await page.locator('input[name="name"]').fill(username);
await page.locator('input[name="pass"]').fill(process.env.APP_SECRET);
Expand Down