Skip to content

Apply Kotlin JVM plugin conditionally#3

Closed
dryfish09 wants to merge 1 commit into
mainfrom
dryfish09-patch-1
Closed

Apply Kotlin JVM plugin conditionally#3
dryfish09 wants to merge 1 commit into
mainfrom
dryfish09-patch-1

Conversation

@dryfish09

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the build.gradle.kts file to disable the automatic application of the Kotlin JVM plugin by adding apply false. The reviewer raised a valid concern that since this is a single-project build, disabling the plugin prevents Kotlin files from being compiled. They suggest either reverting this change or applying the plugin conditionally.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread build.gradle.kts
@@ -1,5 +1,5 @@
plugins {
kotlin("jvm") version "2.4.0"
kotlin("jvm") version "2.4.0" apply false

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Applying the Kotlin JVM plugin with apply false in the plugins block prevents it from being applied to the current project. Since settings.gradle.kts does not define any subprojects, this is a single-project build, meaning the Kotlin plugin is now completely disabled and Kotlin files will not be compiled. If the goal is to apply the plugin conditionally, you need to add the conditional application logic later in this file, for example: if (someCondition) { apply(plugin = "org.jetbrains.kotlin.jvm") }. Otherwise, if Kotlin should always be enabled, please revert this change to apply the plugin directly.

@dryfish09 dryfish09 closed this Jun 18, 2026
@dryfish09 dryfish09 deleted the dryfish09-patch-1 branch June 18, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant