Implement fetching IPFS resources#6
Conversation
Clippy message:
```
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> lib/gofer/src/error.rs:130:1
|
130 | impl Into<std::io::Error> for Error {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
= note: `#[warn(clippy::from_over_into)]` on by default
help: replace the `Into` implementation with `From<error::Error>`
|
130 ~ impl From<Error> for std::io::Error {
131 ~ fn from(val: Error) -> Self {
132 | use std::io::ErrorKind;
133 ~ match val {
```
|
@race-of-sloths include |
|
@SamuelSarle Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 5! @artob received 25 Sloth Points for reviewing and scoring this pull request. We would appreciate your feedback or contribution idea that you can submit here What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
|
@SamuelSarle Don't include lock files in PRs, lest they create merge conflicts between PRs. However, best practice has indeed shifted to keeping the lock file under version control as well. |
artob
changed the title
IPFS resources
|
@race-of-sloths score 5 |
3 participants
Should I include
Cargo.lockchanges here after runningcargo updateto get the latest known-schemes@0.1.1 for theIPFSscheme or should the lockfile be deleted altogether since this is a lib?Verify:
Matches: https://ipfs.io/ipfs/bafybeifx7yeb55armcsxwwitkymga5xf53dxiarykms3ygqic223w5sk3m