Open
Conversation
bstuder
force-pushed
the
wip-dashboard
branch
from
8e96aef to
29f7e4a
Compare
Member
Coverage report
Click to see where and how coverage changed
The report is truncated to 25 files out of 39. To see the full report, please visit the workflow summary page. This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
damienbfs
reviewed
Feb 19, 2026
damienbfs
reviewed
Feb 19, 2026
damienbfs
reviewed
Feb 19, 2026
damienbfs
reviewed
Feb 19, 2026
bstuder
force-pushed
the
wip-dashboard
branch
4 times, most recently
from
5119700 to
f067573
Compare
bstuder
force-pushed
the
wip-dashboard
branch
2 times, most recently
from
ac1a7da to
a632d19
Compare
bstuder
force-pushed
the
wip-dashboard
branch
8 times, most recently
from
ec98b8f to
cbc7118
Compare
fix diffprivlib 0.6.6 & sklearn 1.8.0 issue
damienbfs
reviewed
Mar 9, 2026
damienbfs
reviewed
Mar 9, 2026
Collaborator
There was a problem hiding this comment.
nice to have those examples for functional programming.
Comment on lines
-234
to
-235
| for col in datetime_columns: | ||
| dummy_df[col] = dummy_df[col].dt.strftime("%Y-%m-%dT%H:%M:%S") |
Collaborator
There was a problem hiding this comment.
thanks for cleaning all this
damienbfs
reviewed
Mar 12, 2026
damienbfs
reviewed
Mar 13, 2026
| process-compose = { | ||
| working_dir = "${config.env.DEVENV_ROOT}/server"; | ||
| environment = [ | ||
| "STREAMLIT_SERVER_PORT=${toString cfg.dashboard.port}" |
Collaborator
There was a problem hiding this comment.
I we wanted to be picky I guess we could unify how we configure streamlit?
|
|
||
| @dataset_must_exist | ||
| def set_dataset_metadata(self, dataset_name: str, yaml_file: Path) -> None: | ||
| metadata_dict = yaml.safe_load(yaml_file) |
Collaborator
There was a problem hiding this comment.
Why sometimes hasattr(yaml_file, "resolve") and sometimes not?
| clean=True, | ||
| yaml_file=user_yaml_file, | ||
| add_dex_users: IOResultE = flow( | ||
| config.dex_config, # DexAdminConfig | None |
|
|
||
|
|
||
| @router.get("/datasets") | ||
| def list_datasets( |
Collaborator
There was a problem hiding this comment.
Should these be docummented for the openapi docs?
| lomas_app.state.admin_database = LocalAdminDatabase(path=config.admin_database_url) | ||
| logger.info("Loading authenticator") | ||
| lomas_app.state.authenticator = config.authenticator | ||
| lomas_app.state.bootstrap = config.bootstrap |
Collaborator
There was a problem hiding this comment.
Did I miss the endpoint to disable the boostrap?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dashboard de-coupling: create & use only lomas json-RPC api