xWebAdministration: Moved PHP example from README.md into its own example file#539
xWebAdministration: Moved PHP example from README.md into its own example file#539vikingtiger wants to merge 3 commits intodsccommunity:mainfrom
Conversation
Now reflects that the PHP sample was moved away from README.md into its own .ps1 script file under examples directory.
johlju
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Codecov Report
@@ Coverage Diff @@
## dev #539 +/- ##
=======================================
Coverage 91.72% 91.72%
=======================================
Files 17 17
Lines 2766 2766
=======================================
Hits 2537 2537
Misses 229 229
Continue to review full report at Codecov.
|
johlju
left a comment
There was a problem hiding this comment.
This PR didn't pass the tests. Please resolve the issue.
Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @vikingtiger)
Examples/Resources/Sample_EndToEnd_RegisterPhp.ps1, line 91 at r2 (raw file):
xRemoteFile phpArchive
Please see failing test https://ci.appveyor.com/project/PowerShell/xwebadministration/builds/28331735?fullLog=true#L965
|
The resource xWebAdministration has been renamed. |
Pull Request (PR) description
The PHP example was moved from README.md into its own example file under the
/Examplesdirectory.This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).
and comment-based help.
This change is