fix: basic support to d2s version 105.#86
Open
viniciusrezende wants to merge 1 commit intodschu012:masterfrom
Open
fix: basic support to d2s version 105.#86viniciusrezende wants to merge 1 commit intodschu012:masterfrom
viniciusrezende wants to merge 1 commit intodschu012:masterfrom
Conversation
hyperremix
reviewed
Mar 11, 2026
| } | ||
| } | ||
| if (version === 105 && reader.ReadBit()) { | ||
| reader.SkipBits(8); |
There was a problem hiding this comment.
For Diablo II save files at version 105, item quantity is being silently discarded (SkipBits(8)) instead of parsed. This causes quantity data to be lost when reading stackable items (materials, gems, runes, etc.) from v105 saves. The following change fixes this issue and correctly parses quantities in the new stash tabs in Diablo 2: Reign of the Warlock
Suggested change
| reader.SkipBits(8); | |
| item.quantity = reader.ReadUInt8(8) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds basic support to d2s version 105
Supports Expansion(resurrected) characters/inventory/stash
I didn't test it with stackable items, currency tabs, warlock and new items.