Transport updates - #53
Conversation
|
@elainethale @daniel-thom @ashreeta - I can't explicitly request your review and so informally tagging you here for a review |
|
After spending a little bit more time with the dsgrid docs/code, I modified this to have vehicle stock as it's own metric. |
| electricity_ev_ldv_depot_l2,Commercial Light-Duty EV Depot Level 2 Charging,electricity,kWh | ||
| electricity_ev_ldv_depot_dcfc,Commercial Light-Duty EV Depot DCFC Charging,electricity,kWh | ||
| electricity_ev_ldv_opportunity_dcfc,Commercial Light-Duty EV Opportunity DCFC Charging,electricity,kWh |
There was a problem hiding this comment.
If this is the same as datasets/modeled/transport/dimension_mappings/county_to_county.csv, you can just point to that file rather than duplicating.
There was a problem hiding this comment.
Good point, I just updated to remove the redundant files
| from_id,to_id | ||
| ief_breakthrough,breakthrough | ||
| ief_high,high | ||
| ief_high_inefficient_electrification,inefficient |
There was a problem hiding this comment.
@ashreeta, maybe our inefficient scenario should instead be high_inefficient?
There was a problem hiding this comment.
I'll go with whatever you think is appropriate, a check with the broader team is probably makes sense. Based on the first dataset (Buildings) the current name is 'Inefficient Electrification'. I am not sure Buildings uses the same assumptions as 'high_inefficient'.
There was a problem hiding this comment.
Again, if this is the same as the previous one, can just point to that one (../transport/dimensions/counties.csv). You don't have to duplicate.
|
Just a heads up that by adding the new stock metric, the transport_stock dataset is correctly registering but I'm having issues with the transport dataset, getting the error: What would be the best way to configure these two datasets to properly recognize that the end_use metric is relevant to the transport dataset and the vehicle_stock metric is relevant to the transport_stock dataset and still allow them to share dimensions? |
|
Hi @nreinicke I think the project dimensions might need to be updated, 2 enduses seem to be missing.(https://github.com/nreinicke/dsgrid-project-IEF/blob/ndr/transport-updates/project/dimensions/enduses.csv) . Also this : (https://github.com/nreinicke/dsgrid-project-IEF/blob/ndr/transport-updates/project/dimensions/subset/subsectors_by_sector.csv) needs to be updated if you want to use subset in the stock dataset. Recognizing that 'enduses' is just a name here, without further significance. I could have also named the file 'metrics.csv' |
|
That sounds good, I've updated the project enduse file to include the new transportation end uses. Regarding the subsectors_by_sectors file, when you say it needs to be updated, do you mean I should be adding a new sector for the transportation stock? Lastly, for the stock vehicle metric, would you recommend that I remove the |
|
Hi @nreinicke, yes add transportation stock as a new column and put an x for the relevant metrics. |
@ashreeta, @nreinicke, stock should be a separate dataset. It's units are in no way compatible with enduses. |
|
Hi @elainethale yes he does have it as a seperate dataset. However the subset defined in the config is causing an error. |
|
perfect, thanks. I'll test it as soon as I can and merge it to main once I can confirm. |
Updates to include a new transportation load dataset as well as a transportation vehicle stock dataset. I felt a little awkward adding the vehicle stock as an "enduse" and so I would be curious to hear if there is a better way to include that metric into the project.
All of the data and missing association files are stashed on kestrel at the location:
/projects/evix/evbps/grid-team-deliverables/ief/2025-12-08/aggregations/load-profiles/dsgrid.I have tested registering and submitting with success into my own local registry with the commands:
used spark backend with 2 debug nodes and 8x shuffle partition multiplier
used duckdb backend
dsgrid registry projects register-and-submit-dataset --project-id US_DOE_IEF_2025 --dimension-mapping-file /scratch/nreinick/repos/dsgrid-project-IEF/datasets/modeled/transport_stock/dimension_mappings.json5 --log-message "register transport stock dataset" --data-base-dir /projects/evix/evbps/grid-team-deliverables/ief/2025-12-08/aggregations/load-profiles/dsgrid/ --dataset-config-file /scratch/nreinick/repos/dsgrid-project-IEF/datasets/modeled/transport_stock/dataset.json5 --missing-associations-base-dir /projects/evix/evbps/grid-team-deliverables/ief/2025-12-08/aggregations/load-profiles/dsgrid/