fix kqueue EV_SET bug#7
Open
zt2 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I find using
Net::HTTPwill hangs forever with kqueue on mac like issue #6 , for example:After some researching, I found this problem is trigged in
ext/evt/kqueue.h:EVFILT_READ == ffffffff
EVFILT_WRITE == fffffffe
That makes EVFILT_READ | EVFILT_WRITE == EVFILT_READ and the script will hang on one event.
The result is that "or"-ing them together makes kqueue wait for READ events only. Flags can be "or"-ed but filters should not.
So this patch tries to create two events and this problem is solved.