Fix deadlock when the stream Read starts to respond with 'stream not present'.#7
Open
sgielen wants to merge 1 commit intodslipak:masterfrom
Open
Fix deadlock when the stream Read starts to respond with 'stream not present'.#7sgielen wants to merge 1 commit intodslipak:masterfrom
sgielen wants to merge 1 commit intodslipak:masterfrom
Conversation
…present'. readToken() would never return. If `c` is a space character, and b.eof is false, it would forever call `b.readByte` which would then call reload(), ignore the error it returned, not set b.eof, and return a newline which is still a space character. Now, if the stream Read returns 'stream not present', reload() would set b.eof, stopping the deadlock.
Author
|
I haven't checked why stream Read starts to respond with 'stream not present' - potentially, at that point I believe the root cause here is that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readToken() would never return. If
cis a space character, and b.eof isfalse, it would forever call
b.readBytewhich would then call reload(),ignore the error it returned, not set b.eof, and return a newline which is
still a space character.
Now, if the stream Read returns 'stream not present', reload() would set b.eof,
stopping the deadlock.