Pr3 add join leave UI buttons by haydnli-shopify · Pull Request #2795 · dstackai/dstack

haydnli-shopify · 2025-06-12T15:04:05Z

Summary

Implements join/leave project functionality with an intuitive UI integrated directly into the project members table. This PR builds on the member management endpoints from PR2 to provide a seamless user experience for project collaboration.

Builds on PR2 (#2779) and Issue(#2742) - requires member management endpoints

Changes Made

Frontend Implementation

Integrated join/leave UI into existing ProjectMembers component
Added permission-based button states:
- "Join Project" for non-members of public projects
- "Leave Project" for regular members
- "Owner Cannot Leave" (disabled) for project owners
Added navigation logic to redirect users to project list after leaving projects
Removed redundant "Public Access" section from project Settings page

Translation & Localization

Added translation keys for join/leave operations and success/error messages

User Experience

Join Project Flow

User views a public project they're not a member of
"Join Project" button appears in the members table
Click triggers API call and user becomes project member

Leave Project Flow

User views a project they're a member of (but not owner)
"Leave Project" button appears in members table
Click triggers API call and user is redirected to project list

Permission Handling

Project owners cannot leave (disabled button)
Regular members can leave projects
Non-members can join public projects only

r4victor · 2025-06-13T08:08:46Z

Please address #2759 (comment)

haydnli-shopify · 2025-06-13T14:56:36Z

Please address #2759 (comment)

Thanks for the feedback!
I’ve tested the UI as a non-member on public projects, and the page works as expected—member-only sections aren’t shown, and the UI doesn’t break.
Let me know if you spot any specific issues, but I believe the current logic in #2795 already handles this case well.

r4victor · 2025-06-16T09:53:11Z

@haydnli-shopify, great, we can test it once the PR is ready for review.

haydnli-shopify · 2025-06-16T18:15:54Z

@haydnli-shopify, great, we can test it once the PR is ready for review.

Both ticket are ready for review
PR for backend APIs: #2779
PR for UI: #2795

frontend/src/pages/Project/Form/index.tsx

frontend/src/pages/Project/Details/Settings/index.tsx

frontend/src/pages/Project/Details/index.tsx

frontend/src/pages/Project/Members/index.tsx

frontend/src/pages/Project/Details/index.tsx

peterschmidt85 · 2025-06-20T08:29:03Z

Running on the state of 0.19.15:

  File "/Users/cheptsov/dstack/.venv/lib/python3.13/site-packages/alembic/script/base.py", line 286, in _catch_revision_errors
    raise util.CommandError(resolution) from re
alembic.util.exc.CommandError: Can't locate revision identified by '35e90e1b0d3e'

I assume, the PR branch should merge the changes from the master

peterschmidt85 · 2025-06-20T09:13:55Z

(Minor) I'd suggest to move the UI for managing project visibility to the Danger Zone

peterschmidt85

Ensure you merge the changes from the master (and do a quick test) before merging the PR
Replace /update_visibility with more generic /update
Move the UI for managing the project to Danger Zone. Ensure to use a ComboBox (Public|Private) and ask for a confirmation.
(Optional) Consider showing Visibility in the Projects table as a separate column

frontend/src/api.ts

peterschmidt85 · 2025-06-20T09:20:49Z

Plus, showing Owners Cannot LEave doesn't make sense.

peterschmidt85 · 2025-06-20T09:23:19Z

Also, the Make project public shows the state incorrectly

peterschmidt85

Added a few minor changes. Please review.
If all is good, please confirm so we can merge.

…r projects

…ct updates

…embers

…ty column

r4victor · 2025-06-26T06:55:58Z

src/dstack/_internal/server/routers/projects.py

+async def update_project(
+    body: UpdateProjectRequest,
+    session: AsyncSession = Depends(get_session),
+    user_project: Tuple[UserModel, ProjectModel] = Depends(ProjectManager()),


Project manager can manage project members but otherwise they are regular users, so they should not be able to update projects. Project update must be limited to project admins.

- UI captions - Added confirmation on Leave - Removed Join/Leave from Project Details Header

haydnli-shopify force-pushed the PR3-add-join-leave-ui-buttons branch from 821e634 to fba97cf Compare June 12, 2025 17:54

r4victor mentioned this pull request Jun 13, 2025

Add public projects #2759

Merged

haydnli-shopify force-pushed the PR3-add-join-leave-ui-buttons branch from fba97cf to 7ff0899 Compare June 13, 2025 14:54

haydnli-shopify marked this pull request as ready for review June 16, 2025 18:14

haydnli-shopify mentioned this pull request Jun 16, 2025

Add batch of members endpoints to fix race conditions (#2760) #2779

Closed

haydnli-shopify force-pushed the PR3-add-join-leave-ui-buttons branch from 8e0590c to 7ff0899 Compare June 17, 2025 14:21

peterschmidt85 requested a review from olgenn June 18, 2025 08:11

olgenn requested changes Jun 18, 2025

View reviewed changes

haydnli-shopify requested a review from olgenn June 18, 2025 15:48

olgenn reviewed Jun 18, 2025

View reviewed changes

frontend/src/pages/Project/Details/index.tsx Outdated Show resolved Hide resolved

haydnli-shopify requested a review from olgenn June 18, 2025 18:27

olgenn approved these changes Jun 20, 2025

View reviewed changes

peterschmidt85 self-requested a review June 20, 2025 08:49

peterschmidt85 requested changes Jun 20, 2025

View reviewed changes

frontend/src/api.ts Outdated Show resolved Hide resolved

peterschmidt85 mentioned this pull request Jun 20, 2025

[Feature]: Self-Serve Join/Leave and Better Membership Management #2742

Closed

haydnli-shopify force-pushed the PR3-add-join-leave-ui-buttons branch 4 times, most recently from f6f6a01 to 3417ecb Compare June 23, 2025 15:48

haydnli-shopify requested review from olgenn and peterschmidt85 June 24, 2025 14:32

peterschmidt85 approved these changes Jun 24, 2025

View reviewed changes

haydnli-shopify added 25 commits June 25, 2025 11:17

style: apply pre-commit formatting fixes

f83e3c9

Add project visibility update API endpoint

37fe42c

Fix user autocomplete: allow all users to see user list

846eb09

Fix project deletion permissions: allow project owners to delete thei…

3d0ea5b

…r projects

Apply pre-commit formatting fixes to PR2

52d9212

Fix project deletion permissions and member race conditions

e515981

Allow public project access to gateways endpoints

e3f6ea0

fix: address PR comments from r4victor

36967fe

feat: generalize project update endpoint

beaa33c

refactor: rename /update_visibility to /update for more generic proje…

9e4efaf

…ct updates

Remove redundant comments that duplicate code logic

b589cf4

Remove only redundant comments added in PR2

f61f416

Add join/leave project UI functionality

79920ee

Add Join/Leave button to project header and restrict CLI section to m…

6df964e

…embers

refactor: improve code style and extract member actions hook

8be83d4

refactor: use useProjectMemberActions in ProjectDetails

7722672

Add join/leave project UI functionality

b0bfc08

Add Join/Leave button to project header and restrict CLI section to m…

7edf748

…embers

refactor: improve code style and extract member actions hook

427196c

refactor: use useProjectMemberActions in ProjectDetails

8c8379f

Fix linter errors and remove obsolete updateProjectVisibility mutation

1f425bc

Move project visibility to Danger Zone with ComboBox and add visibili…

8fe5267

…ty column

Fix: Hide 'Leave Project' button for project owners

06f9133

Hide Leave Project button for last admin instead of showing error

863f702

Fix project visibility display issue

cb13d4f

haydnli-shopify force-pushed the PR3-add-join-leave-ui-buttons branch from 12e3f9b to cb13d4f Compare June 25, 2025 15:21

r4victor reviewed Jun 26, 2025

View reviewed changes

Minor changes:

e8a58a7

- UI captions - Added confirmation on Leave - Removed Join/Leave from Project Details Header

peterschmidt85 approved these changes Jun 26, 2025

View reviewed changes

peterschmidt85 merged commit e47c927 into dstackai:master Jun 26, 2025
25 checks passed

Conversation

haydnli-shopify commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes Made

Frontend Implementation

Translation & Localization

User Experience

Join Project Flow

Leave Project Flow

Permission Handling

Uh oh!

r4victor commented Jun 13, 2025

Uh oh!

haydnli-shopify commented Jun 13, 2025

Uh oh!

r4victor commented Jun 16, 2025

Uh oh!

haydnli-shopify commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

peterschmidt85 commented Jun 20, 2025

Uh oh!

peterschmidt85 commented Jun 20, 2025

Uh oh!

peterschmidt85 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

peterschmidt85 commented Jun 20, 2025

Uh oh!

peterschmidt85 commented Jun 20, 2025

Uh oh!

peterschmidt85 left a comment

Choose a reason for hiding this comment

Uh oh!

r4victor Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

haydnli-shopify commented Jun 12, 2025 •

edited

Loading

haydnli-shopify commented Jun 16, 2025 •

edited

Loading