Skip to content

Fix is_public allowing null #2798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r4victor merged 1 commit into from
Jun 13, 2025
Merged

Fix is_public allowing null #2798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/dstack/_internal/server/schemas/projects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from typing import Annotated, List, Optional
from typing import Annotated, List

from pydantic import Field

Expand All @@ -8,7 +8,7 @@

class CreateProjectRequest(CoreModel):
project_name: str
is_public: Optional[bool] = False
is_public: bool = False


class DeleteProjectsRequest(CoreModel):
Expand Down
4 changes: 2 additions & 2 deletions src/dstack/api/server/_projects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from typing import List, Optional
from typing import List

from pydantic import parse_obj_as

Expand All @@ -17,7 +17,7 @@ def list(self) -> List[Project]:
resp = self._request("/api/projects/list")
return parse_obj_as(List[Project.__response__], resp.json())

def create(self, project_name: str, is_public: Optional[bool] = False) -> Project:
def create(self, project_name: str, is_public: bool = False) -> Project:
body = CreateProjectRequest(project_name=project_name, is_public=is_public)
resp = self._request("/api/projects/create", body=body.json())
return parse_obj_as(Project.__response__, resp.json())
Expand Down
Loading