Merged
Conversation
…-efa-version-of-the-default-docker-image
This comment was marked as resolved.
This comment was marked as resolved.
r4victor
reviewed
Jun 16, 2025
r4victor
reviewed
Jun 16, 2025
| @@ -1,3 +1,3 @@ | |||
| __version__ = "0.0.0" | |||
| __is_release__ = False | |||
| base_image = "0.9" | |||
Collaborator
There was a problem hiding this comment.
You should change the image version in the master after the images are built and published, so it's better to change it in a separate PR.
Contributor
Author
There was a problem hiding this comment.
Because we also change the format of the Docker image name, it's not possible to change it in a separate PR.
Moreover, we can build the new VM images from the PR branch before the merge, so it's OK.
Collaborator
There was a problem hiding this comment.
Ok, let's build the images from the PR then and merge when published.
r4victor
reviewed
Jun 16, 2025
r4victor
reviewed
Jun 16, 2025
src/dstack/_internal/server/background/tasks/process_running_jobs.py
Outdated
Show resolved
Hide resolved
r4victor
reviewed
Jun 16, 2025
r4victor
reviewed
Jun 16, 2025
| @@ -1,15 +1,15 @@ | |||
| ARG BASE_IMAGE=dstackai/base:py3.12-0.7-cuda-12.1 | |||
| # syntax = edrevo/dockerfile-plus | |||
Collaborator
There was a problem hiding this comment.
Can we live without it? An unfamiliar dependency that is no longer maintained.
Contributor
Author
There was a problem hiding this comment.
Without this dependency, we would need to duplicate the code
r4victor
reviewed
Jun 16, 2025
src/tests/_internal/server/background/tasks/test_process_running_jobs.py
Outdated
Show resolved
Hide resolved
Roll-backed removing PythonVersion enum; Minor fixes
PR review comments
r4victor
approved these changes
Jun 16, 2025
…and `NCCL_SOCKET_IFNAME` to the base images
…lude`, and `NCCL_SOCKET_IFNAME` to base images. - [x] Updated the list of EFA-enabled AWS EC2 instances
…and NCCL_SOCKET_IFNAME to base images. (bugfix)
un-def
approved these changes
Jun 17, 2025
peterschmidt85
deleted the
2793-ux-pre-build-a-efa-version-of-the-default-docker-image
branch
haydnli-shopify
pushed a commit
to haydnli-shopify/dstack
that referenced
this pull request
Jun 23, 2025
This was referenced Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does:
mpirunand/opt/nvcc-tests/buildto thebaseimagedevel-efaimage that comes with/opt/nvcc-tests/buildanduv(fixes [UX] Pre-build a EFA version of the default Docker image #2793)python(not only minor versions)devel-efaon EFA-enabled AWS instancesOMPI_MCA_pml,OMPI_MCA_btl,OMPI_MCA_btl_tcp_if_exclude,NCCL_SOCKET_IFNAME. See an example.To be done separately:
Staged Docker images: https://hub.docker.com/repository/docker/dstackai/base-stgn/tags?name=ubuntu22.04&page=1