Merged
Conversation
Support rolling deployments for services when the `files` property is updated or the contents of file archives change. Currently, `dstack` always detects phantom changes to file archive contents, since file archives are omitted when getting the run plan. Addressing this is out of scope for this PR. This PR does not address compatibility with previously submitted jobs that are using files, because the files feature has not been released yet, so no users have such jobs.
un-def
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support rolling deployments for services when the
filesproperty is updated or the contents offile archives change.
Currently,
dstackalways detects phantom changesto file archive contents, since file archives are
omitted when getting the run plan. Addressing this
is out of scope for this PR.
This PR does not address compatibility with
previously submitted jobs that are using files,
because the files feature has not been released
yet, so no users have such jobs.
#2180
#2738