Ignore SSH keys when calculating fleet conf diff#2869
Merged
Conversation
Since `/api/project/{project_name}/fleets/get_plan` returns the plan
with sensitive info (SSH keys) removed, the configurations are never
equal. To work around this issue, we exclude (strictly speaking, not
exclude but reset to the default values, `None` in this case) fields
containing SSH key content when calculating the fleet configurations
diff.
Fixes: #2222
r4victor
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
/api/project/{project_name}/fleets/get_planreturns the plan with sensitive info (SSH keys) removed, the configurations are never equal. To work around this issue, we ignore (strictly speaking, not ignore but reset to the default values,Nonein this case) fields containing SSH key content when calculating the fleet configurations diff.Fixes: #2222