Skip to content

Fix run and job status_message calculation#2889

Merged
r4victor merged 2 commits intomasterfrom
pr_run_job_status_message
Jul 11, 2025
Merged

Fix run and job status_message calculation#2889
r4victor merged 2 commits intomasterfrom
pr_run_job_status_message

Conversation

@r4victor
Copy link
Copy Markdown
Collaborator

This PR:

  • Fixes run.status_message to be calculated correctly without accessing all the job submissions (job_submission can be limited after Introduce job_submissions_limit for /api/runs/list  #2883).
  • Makes run.status_message and job.status_message regular calculable fields instead of validators/computed_fields so that they can be computed effectively before serialization and avoid dict() override tricks.
  • Fixed run.status_message calculation in multi-job cases (previously accounted for job[0] only) and worked weirdly with multiple jobs.

The status_message remained the same for most cases.

@r4victor r4victor requested a review from peterschmidt85 July 10, 2025 11:12
@r4victor r4victor merged commit 4b3ff66 into master Jul 11, 2025
26 checks passed
@r4victor r4victor deleted the pr_run_job_status_message branch July 11, 2025 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants