[shim] Don't check image downloaded size#2903
Merged
Conversation
Sometimes dockerd emits less "Download complete" messages than
expected, but the image is pulled successfully.
The reason is unclear, but, anyway, this check is redundant since
we also rely on the status message, which is emitted only
in the case of succesfull pull.
In addition, this patch adds/changes the following:
* Write dockerd pull stream (JSON Lines) to {runnerDir}/pull.log —
useful for debugging (in conjunction with
DSTACK_SERVER_KEEP_SHIM_TASKS=1)
* Use `errorDetail.message` instead of deprecated `error`
* Move `ctx.Err()` check upper, otherwise it's shadowed by pull errors
Fixes: #2503
r4victor
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes dockerd emits less "Download complete" messages than expected, but the image is pulled successfully.
The reason is unclear, but, anyway, this check is redundant since we also rely on the status message, which is emitted only in the case of succesfull pull.
In addition, this patch adds/changes the following:
errorDetail.messageinstead of deprecatederrorctx.Err()check upper, otherwise it's shadowed by pull errorsFixes: #2503