Skip to content

[backends/CloudRift] Fixed issue with terminating inactive instance #2918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jvstme merged 1 commit into from
Jul 21, 2025
Merged

[backends/CloudRift] Fixed issue with terminating inactive instance #2918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/dstack/_internal/core/backends/cloudrift/api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,20 @@ def terminate_instance(self, instance_id: str) -> bool:
logger.debug("Terminating instance with request data: %s", request_data)
response_data = self._make_request("instances/terminate", request_data)
if isinstance(response_data, dict):
logger.debug("Terminating instance with response: %s", response_data)
info = response_data.get("terminated", [])
return len(info) > 0
is_terminated = len(info) > 0
if not is_terminated:
# check if the instance is already terminated
instance_info = self.get_instance_by_id(instance_id)
is_terminated = instance_info is None or instance_info.get("status") == "Inactive"
logger.debug(
"Instance %s is already terminated: %s response: %s",
instance_id,
is_terminated,
instance_info,
)
return is_terminated

return False

Expand Down
Loading