Skip to content

Fix _check_instance log spam #2956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
un-def merged 1 commit into from
Aug 7, 2025
Merged

Fix _check_instance log spam #2956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/dstack/_internal/server/background/tasks/process_instances.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,7 +800,9 @@ async def _check_instance(session: AsyncSession, instance: InstanceModel) -> Non
health_status = instance.health

loglevel = logging.DEBUG
if not instance_check.reachable or (check_instance_health and not health_status.is_healthy()):
if not instance_check.reachable and instance.status.is_available():
loglevel = logging.WARNING
elif check_instance_health and not health_status.is_healthy():
loglevel = logging.WARNING
logger.log(
loglevel,
Expand Down Expand Up @@ -945,7 +947,7 @@ def _check_instance_inner(
except requests.RequestException as e:
template = "shim.%s(): request error: %s"
args = (method.__func__.__name__, e)
logger.warning(template, *args)
logger.debug(template, *args)
return InstanceCheck(reachable=False, message=template % args)
except Exception as e:
template = "shim.%s(): unexpected exception %s: %s"
Expand Down
Loading