Conversation
jvstme
reviewed
Aug 20, 2025
Comment on lines
+652
to
+658
| class Config(CoreModel.Config): | ||
| @staticmethod | ||
| def schema_extra(schema: Dict[str, Any]): | ||
| add_extra_schema_types( | ||
| schema["properties"]["replicas"], | ||
| extra_types=[{"type": "integer"}, {"type": "string"}], | ||
| ) |
Collaborator
There was a problem hiding this comment.
@r4victor, looks like this Config overrides ProfileParams.Config, so the service configuration JSON schema now includes some unnecessary properties like pool_name
https://dstack-runner-downloads-stgn.s3.eu-west-1.amazonaws.com/5458/schemas/configuration.json
Collaborator
Author
There was a problem hiding this comment.
I fixed this and other Config overrides issues in https://github.com/dstackai/dstack/compare/issue_2994_pydantic_stored_types
It's minor, so shouldn't affect the release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A part of #1448
Fixes #2221
Fixes #2294
This PR:
Respects nodes.max for fleet configuration.(this change requires everyone to explicitly define elastic fleets so we'll postpone the enforcement until pre-creating fleets is required)TBD (separate PRs):