Skip to content

[shim] Fix DCGMWrapperInterface nil check #2980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
un-def merged 1 commit into from
Aug 13, 2025
Merged

[shim] Fix DCGMWrapperInterface nil check #2980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion runner/internal/shim/api/handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"errors"
"net/http"
"reflect"

"github.com/dstackai/dstack/runner/internal/api"
"github.com/dstackai/dstack/runner/internal/log"
Expand All @@ -24,7 +25,7 @@ func (s *ShimServer) HealthcheckHandler(w http.ResponseWriter, r *http.Request)
func (s *ShimServer) InstanceHealthHandler(w http.ResponseWriter, r *http.Request) (interface{}, error) {
ctx := r.Context()
response := InstanceHealthResponse{}
if s.dcgmWrapper != nil {
if !reflect.ValueOf(s.dcgmWrapper).IsNil() {
Copy link
Copy Markdown
Collaborator

@r4victor r4victor Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work, but I suppose if implementation changes so that dcgmWrapper is a struct and not a struct pointer, this will panic?

Copy link
Copy Markdown
Collaborator Author

@un-def un-def Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, yes. But we specifically use a pointer to distinguish between cases when DCGM is available and when it's not, it's unlikely that we will change this.

if dcgmHealth, err := s.dcgmWrapper.GetHealth(); err != nil {
log.Error(ctx, "failed to get health from DCGM", "err", err)
} else {
Expand Down
Loading