Skip to content

Exclude target when equal to min for responses #3070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r4victor merged 1 commit into from
Sep 4, 2025
Merged

Exclude target when equal to min for responses #3070

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/dstack/_internal/core/models/fleets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,15 @@ class FleetNodesSpec(CoreModel):
),
] = None

def dict(self, *args, **kwargs) -> Dict:
# super() does not work with pydantic-duality
res = CoreModel.dict(self, *args, **kwargs)
# For backward compatibility with old clients
# that do not ignore extra fields due to https://github.com/dstackai/dstack/issues/3066
if hasattr(res, "target") and res["target"] == res["min"]:
del res["target"]
return res

@root_validator(pre=True)
def set_min_and_target_defaults(cls, values):
min_ = values.get("min")
Expand Down
Loading