Skip to content

Fix long sqlite write transaction when provisioning instances #3104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r4victor merged 1 commit into from
Sep 16, 2025
Merged

Fix long sqlite write transaction when provisioning instances #3104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/dstack/_internal/server/background/tasks/process_instances.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,6 @@ async def _create_instance(session: AsyncSession, instance: InstanceModel) -> No
if placement_group_model is None: # error occurred
continue
session.add(placement_group_model)
await session.flush()
placement_group_models.append(placement_group_model)
logger.debug(
"Trying %s in %s/%s for $%0.4f per hour",
Expand Down Expand Up @@ -636,7 +635,9 @@ async def _create_instance(session: AsyncSession, instance: InstanceModel) -> No
},
)
if instance.fleet_id and _is_fleet_master_instance(instance):
# Clean up placement groups that did not end up being used
# Clean up placement groups that did not end up being used.
# Flush to update still uncommitted placement groups.
await session.flush()
await schedule_fleet_placement_groups_deletion(
session=session,
fleet_id=instance.fleet_id,
Expand Down
Loading