Fix context usage in executor#3223
Closed
matiasinsaurralde wants to merge 1 commit intodstackai:masterfrom
Closed
Conversation
Signed-off-by: Matías Insaurralde <matias@insaurral.de>
This was referenced Oct 24, 2025
r4victor
reviewed
Oct 27, 2025
Collaborator
r4victor
left a comment
r4victor
left a comment
There was a problem hiding this comment.
Overall passing context seems like an improvement but I have concerns about this particular case with moveDir. Suppose context is cancelled while restoreRepoDir – then cp could restore files only partially. This is problematic if repo is stored on a volume.
I think restoreRepoDir shouldn't be cancelled with the run context.
|
This PR is stale because it has been open for 14 days with no activity. |
|
This PR was closed because it has been inactive for 7 days since being marked as stale. Please reopen the PR if it is still relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sharing this small improvement - As we're already using
contextinsetupRepoandexecJobit makes sense to properly pass the context to the other functions.