Disable LEGACY_REPO_DIR with feature flag#3305
Merged
Conversation
Enabling DSTACK_FF_LEGACY_REPO_DIR_DISABLED does the following: - Changes `working_dir` default value from `/workflow` to the image's working dir, unless the client is older than 0.19.27, in which case `/workflow` is still used. - Forbids relative `working_dir` (client side only). - Makes `repos[].path` required, unless the client is older than 0.19.27, in which case `/workflow` is still used Part-of: #3124
un-def
deleted the
issue_3124_ditch_legacy_repo_dir_with_feature_flag
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling DSTACK_FF_LEGACY_REPO_DIR_DISABLED does the following:
working_dirdefault value from/workflowto the image's working dir, unless the client is older than 0.19.27, in which case/workflowis still used.working_dir(client side only).repos[].pathrequired, unless the client is older than 0.19.27, in which case/workflowis still usedPart-of: #3124