Update lib/local-storage.js to ES2015#242
Open
Nathan-Schwartz wants to merge 23 commits intodthree:masterfrom
Open
Update lib/local-storage.js to ES2015#242Nathan-Schwartz wants to merge 23 commits intodthree:masterfrom
Nathan-Schwartz wants to merge 23 commits intodthree:masterfrom
Conversation
Conflicts: dist/command.js dist/option.js lib/command.js
Rename variable from Vantage to Vorpal
Updated dev deps and switched to Yarn
Updated Inquirer to v3 and other prod deps
…values Support default values for options
Remove dist folder
…ig for Babel and ESLint.
Update babel/eslint build config
Convert commands to ES2015
Contributor
|
I feel like this entire file can be removed. It's almost a 1:1 map of the native For example, this is the current code: vorpal.localStorage = function (id) {
var ls = Object.create(LocalStorage);
ls.setId(id);
_.extend(this.localStorage, ls);
return this;
};Which can be changed to: vorpal.localStorage = function (id) {
if (!id) {
throw new Error('vorpal.localStorage() requires a unique key to be passed in.');
}
Object.assign(this.localStorage, new LocalStorage(DEFAULT_STORAGE_PATH + id));
return this;
};I haven't tested it yet, but worth a shot. |
Owner
|
Agreed. Go for it. |
Contributor
Author
|
Sounds good to me. Seems like we can close this. @milesj Would you like to take a crack at reusing |
Contributor
|
Yeah I can take a look at it. I'll leave this PR open in case it doesn't work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests and linter pass. Runs in Node without babel.