Add borsh as an optional dependencies#347
Open
BoyeGuillaume wants to merge 8 commits intodtolnay:masterfrom
Open
Add borsh as an optional dependencies#347BoyeGuillaume wants to merge 8 commits intodtolnay:masterfrom
BoyeGuillaume wants to merge 8 commits intodtolnay:masterfrom
Conversation
Because the identifier is the "manual" unsafe implementation we only test this side, the rest use the derive macro (so stable)
This is a bit of a "lets hide the problem under the rug" but i don't think we can do much better in this scenario.
Oups i missed one
Author
|
Mmm it seems that borsh itself have dependencies that doesn't support the rust version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add
borshas an optional dependency this repository