Conversation
ecpeterson
commented
Nov 3, 2025
karalekas
requested changes
Nov 16, 2025
karalekas
requested changes
Nov 16, 2025
Member
karalekas
left a comment
There was a problem hiding this comment.
also I would really like to see that unit test or two
karalekas
requested changes
Nov 16, 2025
Member
karalekas
left a comment
There was a problem hiding this comment.
also, as discussed offline, id be very interested to see a third network variant that includes both NN and quadtree links, and prioritizes NN links when using them would result in a better routing time
while ofc the quadtree routing time is asymptotically better for long-distance routing, we expect in practice to do a lot of NN routing and it seems non-ideal to double the NN routing time in the quadtree network configuration
Member
|
added a minimal unit test; you'll need to pull @ecpeterson |
11bfc6a to
448d2e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
ceil.little demo: