Implement recursive search for folder#8
Open
maufirf wants to merge 1 commit intodtsvetkov1:masterfrom
Open
Conversation
This also includes a reminder that string split using "/" sometimes don't work as windows uses "\\", and a little change of the Drive API Query to make sure it looks only for the file that are not trashed in Drive, often times prior to this change it will download trashed files too to local.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original folder search only searches the Drive folder on root, and generates one in root if not found. This changes enables you to search the folder with exact name recursively and only when the folder on the exhaustive search isn't found, it will fall back into making one in the root. The comparison between two strings also changed into comparing two lists of char integer ord() equivalent sequences due to strange behavior of comparing the strings directly which can return false even if the string is exactly the same.
This also includes a reminder that string split using "/" sometimes don't work as windows uses "\", and a little change of the Drive API Query to make sure it looks only for the file that are not trashed in Drive, often times prior to this change it will download trashed files too to local.
Also, a small note that Drive always has wrong timestamp for some reason, it's always hours late compared to the actual time the file got uploaded.