⚡ bolt: [performance improvement] cache PhotoCarousel visibility with IntersectionObserver#26
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Deploying personal-website with
|
| Latest commit: |
0976368
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://21790e5b.personal-website-5ns.pages.dev |
| Branch Preview URL: | https://bolt-photo-carousel-observer.personal-website-5ns.pages.dev |
1 participant
💡 what: added an
IntersectionObserverto thePhotoCarouselobject inscript.jsto cache the visibility state (this.isVisible). updatedisInView()to return this boolean instead of callinggetBoundingClientRect().🎯 why: calling
getBoundingClientRect()inside high-frequency event listeners likekeydown(for carousel navigation) forces synchronous layout recalculation, leading to layout thrashing and degraded responsiveness.📊 impact: eliminates forced synchronous layouts during keyboard navigation of the carousel, ensuring smoother interactions and lower main thread usage.
🔬 measurement: verified via playwright that the photo carousel still correctly tracks visibility and navigates via keyboard when in view.
PR created automatically by Jules for task 11373921311909301465 started by @dttdrv