fix(cron): restore management actions after scan result change - #89
Open
Linxiushen wants to merge 1 commit into
Open
fix(cron): restore management actions after scan result change#89Linxiushen wants to merge 1 commit into
Linxiushen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
manage_cronstatus, list, and manual-run actions after thescan_jobs()return contract expanded(valid_jobs, invalid_mtimes)at each direct management consumer while leaving invalid-file tracking with the schedulerRoot cause
scan_jobs()now returns(valid_jobs, invalid_mtimes), but these three consumers still treated the complete tuple asList[CronJob]. They consequently attempted to readCronJobattributes from the tuple's list or dictionary members and returned caughtAttributeErrorfailures.Testing
test_manage_cron_scan_result.pyandtest_cron_model_payload.py)git diff --checkFixes #88