Skip to content

fix(cron): restore management actions after scan result change - #89

Open
Linxiushen wants to merge 1 commit into
dtyq:masterfrom
Linxiushen:fix/cron-scan-result-contract
Open

fix(cron): restore management actions after scan result change#89
Linxiushen wants to merge 1 commit into
dtyq:masterfrom
Linxiushen:fix/cron-scan-result-contract

Conversation

@Linxiushen

Copy link
Copy Markdown

Summary

  • restore manage_cron status, list, and manual-run actions after the scan_jobs() return contract expanded
  • unpack (valid_jobs, invalid_mtimes) at each direct management consumer while leaving invalid-file tracking with the scheduler
  • add focused regression coverage for status rendering, disabled-job filtering, and manual execution lookup

Root cause

scan_jobs() now returns (valid_jobs, invalid_mtimes), but these three consumers still treated the complete tuple as List[CronJob]. They consequently attempted to read CronJob attributes from the tuple's list or dictionary members and returned caught AttributeError failures.

Testing

  • targeted pytest: 4 passed (test_manage_cron_scan_result.py and test_cron_model_payload.py)
  • Ruff check and format check on the new test file
  • Python bytecode compilation for the changed source and test files
  • git diff --check

Fixes #88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(cron): restore status, list, and manual run after scan contract change

1 participant