Skip to content

Bump cmake_minimum_required #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mytherin merged 4 commits into from
Apr 4, 2025
Merged

Bump cmake_minimum_required #35

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35e6d0e
Bump cmake_minimum_required
carlopi Apr 3, 2025
d33aa13
Pass CMAKE_POLICY_VERSION_MINIMUM down to arrow
carlopi Apr 3, 2025
2c899ac
Set x
carlopi Apr 3, 2025
f09de6f
Set also via ENV
carlopi Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 2.8.12)
cmake_minimum_required(VERSION 3.5...3.29)

# Set extension name here
set(TARGET_NAME arrow)
Expand All @@ -16,6 +16,10 @@ else()
set(OSX_ARCH_FLAG "")
endif()

# Do they actually work?
set(CMAKE_POLICY_VERSION_MINIMUM 3.5)
set(ENV{CMAKE_POLICY_VERSION_MINIMUM} 3.5)

# Building Arrow
include(ExternalProject)
ExternalProject_Add(
Expand Down Expand Up @@ -45,6 +49,7 @@ ExternalProject_Add(
-DARROW_WITH_LZ4=OFF -DARROW_WITH_SNAPPY=OFF -DARROW_WITH_ZLIB=OFF
-DARROW_WITH_ZSTD=OFF -DARROW_WITH_UCX=OFF -DARROW_WITH_UTF8PROC=OFF
-DARROW_WITH_RE2=OFF <SOURCE_DIR>/cpp
-DCMAKE_POLICY_VERSION_MINIMUM=3.5
CMAKE_ARGS -Wno-dev
UPDATE_COMMAND "")

Expand Down