[DBAPI2.0] Fix the description attribute#43
Merged
evertlammerts merged 6 commits intoSep 11, 2025
Conversation
This was referenced Sep 10, 2025
evertlammerts
left a comment
evertlammerts
left a comment
Member
There was a problem hiding this comment.
From the spec it's not clear what type_code is expected to be. Psycopg returns the type's OID and mysql returns a type id, both of which are numbers, but I don't see a good reason to not return a DuckDBPyType...
Co-authored-by: Evert Lammerts <evertlammerts@users.noreply.github.com>
Tishj
force-pushed
the
dbapi2_description_fixes
branch
from
bdda2b6 to
787d12d
Compare
… but with a much smaller change
Merged
via the queue into
duckdb:v1.4-andium
with commit Sep 11, 2025
d202b0c
65 of 66 checks passed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/duckdblabs/duckdb-internal/issues/1217, duckdb/duckdb#10495
This PR should make a better attempt at implementing https://peps.python.org/pep-0249/#type-objects-and-constructors
We add the required type object sentinels:
STRINGNUMBERDATETIMEBINARYROWID(None, as DuckDB doesn't have a way to detect this on a LogicalType)The objects returned for the
type_codeof thedescriptionis aDuckDBPyType.The sentinels are of type
DBAPITypeObjectand are overloaded to be compared with theDuckDBPyTypeobjects.The constructors listed by the PEP are not added, they could be added in the future.