Skip to content

[Dev] Add py::is_operator() where appropriate for the DuckDBPyExpression interface#44

Merged
evertlammerts merged 2 commits into
duckdb:v1.4-andiumfrom
Tishj:pyexpression_is_operator
Sep 15, 2025
Merged

[Dev] Add py::is_operator() where appropriate for the DuckDBPyExpression interface#44
evertlammerts merged 2 commits into
duckdb:v1.4-andiumfrom
Tishj:pyexpression_is_operator

Conversation

@Tishj

@Tishj Tishj commented Sep 10, 2025

Copy link
Copy Markdown
Member

See https://pybind11.readthedocs.io/en/stable/advanced/classes.html#operator-overloading

This makes it play nicer with the fallbacks that python provides for operator methods

@evertlammerts evertlammerts left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks! putting this into 1.4.0 :-)

@evertlammerts evertlammerts added this pull request to the merge queue Sep 15, 2025
Merged via the queue into duckdb:v1.4-andium with commit d7df331 Sep 15, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants