[Dev] Move PyArrow filter pushdown to separate file#51
Merged
Conversation
Member
|
Ha, love it, frustration driven cleanup, go for it :-) Re Makefile: I have a relatively strong preference to not have one here unless we must, and then not one that depends on scripts in the duckdb submodule. I have a branch where I'm adding the linting and formatting rules. I'm planning to add pre-commit there to run all clang-format and clang-tidy stuff. That integrates nicely with git workflows and CI. I'm hoping to merge this post the 1.4.0 release. |
Member
Author
|
Sure, using a Makefile is kind of "the duckdb way", so not having one entirely is kind of creating friction for duckdb maintainers to come in and contribute here, which is something to be aware of But I'll rip it out for now |
evertlammerts
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has annoyed me for some time, needing to remember the filter pushdown logic is defined in
arrow_array_stream.cppwhich is completely illogicalCleaned it up, added a Makefile for
make format-main, and extended the import cache to get rid of some rawpy::_module::importcalls