ignore FLATNOTES_PORT on kubernetes

[sparksis]

Fix for #187

[sparksis]

Validate truth table with test.sh

resulting in output:

Using docker, not explicitly overwritten
FLATNOTES_PORT=
KUBERNETES_PORT=
Selected Port: 8080


Using docker, explicitly overwritten
FLATNOTES_PORT=1234
KUBERNETES_PORT=
Selected Port: 1234


Using kubernetes, not explicitly overwritten
FLATNOTES_PORT=tcp://127.0.0.1:80
KUBERNETES_PORT=tcp://127.0.0.1:80
Warning: ignoring FLATNOTES_PORT=tcp://127.0.0.1:80 on kubernetes
Selected Port: tcp://127.0.0.1:80


Using kubernetes, explicitly overwritten
FLATNOTES_PORT=1234
KUBERNETES_PORT=tcp://127.0.0.1:80
Warning: ignoring FLATNOTES_PORT=1234 on kubernetes
Selected Port: 1234


Not a real scenario
FLATNOTES_PORT=
KUBERNETES_PORT=tcp://127.0.0.1:80
Selected Port: 8080

[reddec]

Could be fixed in manifest by enableServiceLinks: false

apiVersion: apps/v1
kind: Deployment
metadata:
  name: "..."
spec:
  selector:
    matchLabels:
      kind: "..."
  template:
    metadata:
      labels:
        kind: "..."
    spec:
      enableServiceLinks: false

[sparksis]

Indeed, would you like me to update the readme in this PR instead?

[dullage]

Thanks for the PR.

The setting of the environment variables in entrypoint.sh is a workaround for Synology users. Both are set in the Dockerfile, which should be enough, but when Synology users updated (from a version that didn't contain these env vars) they weren't being loaded until the container was recreated (see #178).

This makes me hesitant to merge this PR as it would be a workaround for something caused by another workaround. I might dig into the Synology issue more first, as it might be a bug that's on their radar (in which case I could take this out of entrypoint.sh once it's fixed).