Fix SQLite analyzer permission error flags#598
Open
sjh9714 wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #598 +/- ##
==========================================
+ Coverage 85.45% 85.49% +0.04%
==========================================
Files 55 55
Lines 6173 6177 +4
==========================================
+ Hits 5275 5281 +6
+ Misses 691 690 -1
+ Partials 207 206 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #591.
When the SQLite analyzer scanned a readable directory that contained an unreadable descendant, the descendant kept its
!flag but the parent directory row kept its original blank flag. This made non-interactive--dboutput miss the.warning prefix for parent directories whose totals may be incomplete.Changes
!/.flags to the finalized parent directory flag.Testing
go test ./pkg/analyze -run TestSqliteAnalyzerPropagatesChildPermissionError -count=1(failed before the fix, passed after)go test -v -covermode=count ./...go build -o /tmp/gdu-pr-591-fixed ./cmd/gdugo vet ./...gdu --no-progress --no-color --no-prefix --non-interactive --db <tmp>/gdu.sqlite <tmp>/myfolderNote: I used Codex while preparing this change, and I reviewed the final diff and ran the listed checks locally.