Cert pin changes - #59
Merged
Merged
Conversation
AaronAtDuo
reviewed
Jun 24, 2026
owenkelley-1
force-pushed
the
cert-pin-changes
branch
from
June 25, 2026 16:30
354e3aa to
e060eaf
Compare
AaronAtDuo
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ca_certs.pemfile and full X.509 certificate comparison with SPKI (SubjectPublicKeyInfo) hash pinning using base64-encoded SHA-256 hashesClientBuilder) are automatically converted to SPKI hashes for consistent pinning behaviorca_certs.pemresource from the buildMotivation and Context
SPKI hash pinning is more resilient to certificate re-issuance — when a CA renews a certificate with the same key pair, the SPKI hash stays the same while the full certificate bytes change. This avoids unnecessary breakage when Duo's CAs rotate certificates. It also aligns with industry standard pinning approaches (RFC 7469, Chrome, curl).
Test plan
TestGetDuoSpkiHashesconfirms all 15 pinned hashes are presentHow Has This Been Tested?
Added unit tests and tested with bundled DLL on ADFS product.
Types of Changes