Skip to content

Add CA bundle version and pinning status to the user agent string - #63

Merged
AaronAtDuo merged 1 commit into
mainfrom
user-agent-ca-pinning
Jul 22, 2026
Merged

Add CA bundle version and pinning status to the user agent string#63
AaronAtDuo merged 1 commit into
mainfrom
user-agent-ca-pinning

Conversation

@cisco-dmytro-hissa

Copy link
Copy Markdown
Contributor

Description

  • Added CA_BUNDLE ("ca_bundle") and CA_BUNDLE_VERSION ("1.0") constants to Client.cs.
  • Appended ca_bundle/1.0 to the user agent string.
  • Appended (ca_pinning=enabled) / (ca_pinning=disabled) to the user agent string, derived from the current runtime state.
  • Pinning reports disabled when either DisableCertificatePinning() or DisableSslCertificateValidation() is used, matching actual behavior (no pinning is performed when SSL validation is off).

How Has This Been Tested?

  • TestUserAgentCaBundleVersion — verifies ca_bundle/1.0 is present in the user agent.
  • TestUserAgentCaPinningEnabledByDefault — verifies (ca_pinning=enabled) appears by default.
  • TestUserAgentCaPinningDisabled — verifies (ca_pinning=disabled) after DisableCertificatePinning().
  • TestUserAgentCaPinningDisabledWhenSslValidationDisabled — verifies (ca_pinning=disabled) after DisableSslCertificateValidation().

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@cisco-dmytro-hissa
cisco-dmytro-hissa marked this pull request as ready for review July 22, 2026 16:04
@AaronAtDuo
AaronAtDuo merged commit a1c5f92 into main Jul 22, 2026
3 checks passed
@AaronAtDuo
AaronAtDuo deleted the user-agent-ca-pinning branch July 22, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants