Add CA bundle version and pinning status to the user agent string - #63
Merged
Conversation
cisco-dmytro-hissa
marked this pull request as ready for review
July 22, 2026 16:04
AaronAtDuo
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CA_BUNDLE("ca_bundle") andCA_BUNDLE_VERSION("1.0") constants toClient.cs.ca_bundle/1.0to the user agent string.(ca_pinning=enabled)/(ca_pinning=disabled)to the user agent string, derived from the current runtime state.disabledwhen eitherDisableCertificatePinning()orDisableSslCertificateValidation()is used, matching actual behavior (no pinning is performed when SSL validation is off).How Has This Been Tested?
TestUserAgentCaBundleVersion— verifiesca_bundle/1.0is present in the user agent.TestUserAgentCaPinningEnabledByDefault— verifies(ca_pinning=enabled)appears by default.TestUserAgentCaPinningDisabled— verifies(ca_pinning=disabled)afterDisableCertificatePinning().TestUserAgentCaPinningDisabledWhenSslValidationDisabled— verifies(ca_pinning=disabled)afterDisableSslCertificateValidation().Types of Changes