fix(backend): stop logging intentional HttpErrors as unhandled errors#1685
fix(backend): stop logging intentional HttpErrors as unhandled errors#1685Anexus5919 wants to merge 1 commit into
Conversation
|
@Anexus5919 is attempting to deploy a commit to the durdana3105's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Warning Review limit reached
Next review available in: 29 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@durdana3105 Kindly have a review on this pr. Thanks! |
Summary
The global error handler had an unconditional
console.error("Unhandled error:", err)before it classified the error, so every intentionalHttpErrorwas logged twice, and expected 4xx client errors were recorded as unhandled server errors. This removes the stray line and logs 4xx at warn, 5xx at error.Changes
errorHandler.js: remove the unconditional log; log HttpError at warn (status < 500) or error (>= 500).tests/errorHandler.test.js.Verification
Related
Fixes #1661